https://bugzilla.redhat.com/show_bug.cgi?id=982705 Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> --- Hello Allan, Few comments: - * Fri Jul 9 2013 Allan Roque <allanrafaelroque@xxxxxxxxx> - 1.0.5-1 ==> Jul 9 is not Friday. ;-) - meme.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/meme/meme.py 0644L /usr/bin/env ===> This one can be ignored. However, I would suggest you to talk with upstream people to remove the shebang since users aren't really going to execute the file directly, so why have a shebang line? - %check # No present in source ==> Your spec say that there are no tests but looks like the source code provides (see below). Can you please double check? $ ls upstream-unpacked/Source0/memepy-a1e32491a9996ef881c401b9dc4e753d2f8af24b/meme/tests/ action_result.json info.json __init__.py popular.json search.json test_meme.py - Please make sure you increase the release for next review. To get sponsored you need to do at least 2 informal package review [1]. Basically, you can pick up a random bugzilla that is requesting a package review and push your comments there (don't need to assign it) and share the links here. To help you in this task, I can suggest: - FedoraReview - Fedora Hosted https://fedorahosted.org/FedoraReview/ - Package Review Guidelines http://fedoraproject.org/wiki/Packaging:ReviewGuidelines - Package Review Guidelines for Java http://fedoraproject.org/wiki/Packaging:Java - Package Review Guidelines for Python http://fedoraproject.org/wiki/Packaging:Python [1] https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Please let me know if you have any question. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=COelq7shlq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review