https://bugzilla.redhat.com/show_bug.cgi?id=947819 --- Comment #12 from Jens Petersen <petersen@xxxxxxxxxx> --- Thanks Ricky for reviewing > - Static libraries in -static subpackage, if present. > Note: Archive *.a files found in idris > See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries > > (This might be a result of > https://fedoraproject.org/wiki/Packaging:Haskell#Static_vs._Dynamic_Linking > and allowable. (cf also the newer approved https://fedoraproject.org/wiki/PackagingDrafts/Haskell#Shared_and_static_library_linking) > Can you comment?) Well I agree it would be nicer to have a shared dynamic runtime library. But given that currently there is only a static one and idris is still kind of experimental I think the packaging is probably okay for now: given the status quo I don't really see a point in subpackaging the static library. Maybe if we come to packaging projects written in Idris some day we should revisit this - but most distros don't even use dynamic linking for Haskell executables yet (unlike Fedora)... The other problem is that adding a -devel subpackage will probably make idris multilib which is a bit silly IMHO. But see also more comments below. :) > - Header files in -devel subpackage, if present. > Note: idris : > /usr/lib64/idris-0.9.8/rts/idris_bitstring.h idris : > /usr/lib64/idris-0.9.8/rts/idris_gc.h idris : > /usr/lib64/idris-0.9.8/rts/idris_gmp.h idris : > /usr/lib64/idris-0.9.8/rts/idris_heap.h idris : > /usr/lib64/idris-0.9.8/rts/idris_opts.h idris : > /usr/lib64/idris-0.9.8/rts/idris_rts.h idris : > /usr/lib64/idris-0.9.8/rts/idris_stats.h idris : > /usr/lib64/idris-0.9.8/rts/idris_stdfgn.h > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > > (I am assuming that these header files are required at runtime? Or can we > move them into a -devel subpackage?) Right - they are needed when compiling idris code into an executable. Personally I would prefer just to keep the current packaging. While the idris interpreter can run without the rts files - some functionality like compilation will not work. idris would have to require idris-devel anyway. IMHO since idris is a development package it doesn't need to have a devel subpackage (at this time anyway). > - idris.x86_64: W: executable-stack /usr/bin/idris > > (See this link for help with getting rid of this warning: > https://fedoraproject.org/wiki/Packaging_tricks#Executable_stack) See bug 973512. I sent a mail to the ghc users list yesterday and this got fixed already upstream yesterday. I just backported the patch to ghc-7.6.3-15.fc20 so far, but not actually tested yet... > - Spec use %global instead of %define. > Note: %define cabal_configure_options --datadir=%{_libdir} > > (Use %global instead :)) Okay - though it was intentional (since it's only needed for the %build section). Anyway let me replace it with a variable. :) Spec: http://petersen.fedorapeople.org/reviews/idris/idris.spec SRPM: http://petersen.fedorapeople.org/reviews/idris/idris-0.9.8-3.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5589311 (built with ghc-7.6.3-15.fc20) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S6FU9Oc1y0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review