https://bugzilla.redhat.com/show_bug.cgi?id=982679 Troy Dawson <tdawson@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tdawson@xxxxxxxxxx --- Comment #1 from Troy Dawson <tdawson@xxxxxxxxxx> --- I'm working on a review, but I have two questions. Bundling: It has a /vendor/ directory, that has the twitter bootstrap code in it. Normally this screams "bundling". But, this is what it says in the packaging guidelines "At this time JavaScript intended to be served to a web browser on another computer is specifically exempted from this but this will likely change in the future." https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries "Twitter" in the summary and description: I'm always nervous about putting a trademarked name in a summary and/or description. I liked what a previous review attempt had for theirs. https://raw.github.com/mojavelinux/rubygem-bootstrap-sass-rpm/master/rubygem-bootstrap-sass.spec Thoughts on either of these items? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gwu7SMBq9x&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review