https://bugzilla.redhat.com/show_bug.cgi?id=976468 --- Comment #8 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Consider to package this gem as an Application - I am not sure if this gem has any meaning as a gem, i.e. if it can be used Ruby library. Have you considered the possibility to package it as an application [1]? * Please execute test suite - The gem ships with test suite, could you please execute it during build? * Exclude hidden files - Although you exclude .gitignore file, you keep .travis.yml in package. I would suggest to exclude both using %exclude %{gem_instdir}/.* * Move files not needed for runtime into -doc subpackage - Please consider move of examples, spec, Gemfile, README.md and Rakefile into -doc subpackage, since they are not needed for runtime. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Applications -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nSr3JUfuDy&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review