[Bug 980071] Review Request: python-xpyb - X Python Binding, based on the X C Binding (XCB) library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=980071

--- Comment #8 from Tomas Dabašinskas <tdabasin@xxxxxxxxxx> ---
Hi all many thanks for the feedback.

Mario,
I have updated the requires to include %{?_isa}

Christopher,
The license on pipy site says it's Public Domain
https://pypi.python.org/pypi/xpyb,
I'm not sure if I'm defining correctly as rpmlint says it doesn't know that
license type. 

Michael,
I have included devel subpackage requires for libxcb-devel and python2-devel,
libxcb is required for libxcb-devel, should I say requires: libxcb anyway?
doc dir, and one other dir updated


Can anyone please tell me how do I go about removing xcb.la and INSTALL files?
I can't find anything on the wiki

Many thanks for your time everyone.

Spec URL:
http://people.fedoraproject.org/~tdabasin/python-xpyb/python-xpyb.spec
SRPM URL:
http://people.fedoraproject.org/~tdabasin/python-xpyb/python-xpyb-1.3.1-1.fc19.src.rpm


--- python-xpyb.spec.old        2013-07-06 19:31:55.714203065 +1000
+++ python-xpyb.spec    2013-07-06 20:12:14.372602110 +1000
@@ -21,7 +21,9 @@

 %package devel
 Summary:       Devel files of xpyb
-Requires:      %{name} = %{version}-%{release}
+Requires:      %{name}%{?_isa} = %{version}-%{release}
+Requires:      libxcb-devel
+Requires:      python2-devel

 %description devel
 This package provides devel files of xpyb, a Python binding to the
@@ -39,8 +41,8 @@
 %make_install

 %files
-%{python_sitearch}/*
-%doc %{_docdir}/xpyb/*
+%{python_sitearch}/xcb/
+%{_docdir}/xpyb/

 %files devel
 %{_libdir}/pkgconfig/xpyb.pc
@@ -48,7 +50,7 @@

 %changelog
 * Mon Jul 01 2013 Tomas Dabasinskas <tomas@xxxxxxxxxx> - 1.3.1-1
-- Minor edits for inclusion to fedora yum repo
+- Edits for inclusion to fedora yum repo
 * Sat Apr 20 2013 Huaren Zhong <huaren.zhong@xxxxxxxxx> - 1.3
 - Rebuild for Fedora
 * Mon Apr  8 2013 mlin@xxxxxxxx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RwPoWE8RgJ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]