https://bugzilla.redhat.com/show_bug.cgi?id=978489 --- Comment #2 from Debarshi Ray <debarshir@xxxxxxxxxx> --- Spec: http://rishi.fedorapeople.org/dleyna-connector-dbus.spec SRPM: http://rishi.fedorapeople.org/dleyna-connector-dbus-0.1.0-2.fc19.src.rpm (In reply to Mathieu Bridon from comment #1) > Package is almost good to go, there's just a few little things to fix. > > Summary > ======= > > [!]: Package requires other packages for directories it uses. > [!]: Package must own all directories that it creates. > > => Package installs > %{_libdir}/dleyna-%{api}/connectors/libdleyna-connector-dbus.so > but does not provide the %{_libdir}/dleyna-%{api} and > %{_libdir}/dleyna-%{api}/connectors folders. > > => Maybe the right fix here would be to have dleyna-core provide these > folders (it does not at the moment) and then dleyna-connector-dbus > could just explicitly require dleyna-core? Good catch. To me it seemed more sane to have dleyna-connector-dbus own those two directories. eg., I don't know if other dLeyna components will be creating more such directories. Up to you. > > [!]: Spec use %global instead of %define. > Note: %define api 1.0 > > => Just s/define/global/ in that line. Done. > [!]: Final provides and requires are sane (see attachments). > > => Should the private .so file be filtered from provides? > This is a real question, I can't answer it as I don't know what this > file is supposed to do. I'll trust your judgement on this point. I don't know either. dLeyna supports different IPC mechanisms (see connector-name in /etc/dleyna-renderer-service.conf) via a plugin architecture. This particular file implements support for D-Bus. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V11yFdBDVb&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review