https://bugzilla.redhat.com/show_bug.cgi?id=981971 --- Comment #2 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Thank you @cicku (In reply to Christopher Meng from comment #1) > No big problem. > > 1. main.py under %{python_sitelib}/landslide has env. rpmlint showed: > > Requires > -------- > python-landslide (rpmlib, GLIBC filtered): > /usr/bin/env > (snip) > > Ah, maybe should be patched, right? Not necessarily, although that is a good practice is a "SHOULD", anyway, is fixed in 2 > > 2. MANIFEST.in should be removed from %doc. Yes, you're right Fixed in 2 > 3. Do you think it's a good idea or not that creating a subpackage "doc" to > store the htmls? the complete documentation is approximately of 260 KB,thinking about the meaning of "large documentation", in this case don't applicable, see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#PackageDocumentation > 4. rpmlint warned me about the license, seems that > %{python_sitelib}/landslide/watcher.py has no license header. Yes, watcher.py hasn't license header, but i don't see any rpmlint warning about that. rpmlint -v python-landslide-1.1.1-1.fc19.src.rpm python-landslide.src: I: checking python-landslide.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.src: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows python-landslide.src: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.src: I: checking-url https://github.com/adamzap/landslide/archive/a0078400c8e8f2fe19a754c0dbd55e7a3dbb796d/landslide-1.1.1-a007840.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint -v python-landslide-1.1.1-1.fc19.noarch.rpm python-landslide.noarch: I: checking python-landslide.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow, slide show, slide-show python-landslide.noarch: W: spelling-error %description -l en_US slideshows -> sideshows, slide shows, slide-shows anyway the package contains the boilerplate of the Apache License python-landslide.noarch: I: checking-url https://pypi.python.org/pypi/landslide (timeout 10 seconds) python-landslide.noarch: W: no-manual-page-for-binary landslide 1 packages and 0 specfiles checked; 0 errors, 3 warnings. anyway the package contains the boilerplate of the apache license SPEC: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide.spec SRPM: http://echevemaster.fedorapeople.org/python-landslide/2/python-landslide-1.1.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J2wm4qHQG6&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review