Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: grass - GRASS (Geographic Resources Analysis Support System) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227646 ------- Additional Comments From cbalint@xxxxxxxxxx 2007-03-14 10:17 EST ------- updated. Spec URL: http://openrisc.rdsor.ro/grass.spec SRPM URL: http://openrisc.rdsor.ro/grass-6.2.1-9.src.rpm rpmlint: W: grass-devel no-dependency-on grass (In reply to comment #27) > Created an attachment (id=149205) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149205&action=view) [edit] > rpmlint log of grass-6.2.1-9 with two BR added > > Well, for -9: > > * BuildRequires: > - As said before, "libtiff-devel libpng-devel" are missing at least. updated. > - Please check the following. > ------------------------------------------------------ > checking for mysql_config... /usr/bin/mysql_config > checking for mysql_server_init... no > configure: warning: libmysqld not found > ------------------------------------------------------ fixed. > * Requires (expecially for -devel) package > - Check the Requirement for -devel package. > @ Usually this can be checked by what files the header files > in -devel package try to "include". done. > @ And usually these dependencies should correcly appear on > pkgconfig .pc file as "Requires:" section added. > @ And the requirement for pkgconfig is missing added. > * Source > - Please specify URLs of all sources (if possible), especially > Source2. done. > * Timestamps > - This package contains a lot of text files (such as header files, > scripts), image files and so. > Please keep timestamps on those files. ouch. well need to relocate lots of places, so i done lots of 'mv', well, i would be happy to hint how to do it better, idea ? > * rpmlint (check attached) > + incoherent-version-in-changelog fixed. > (This is because I increased the release number to add missing > BuildRequires) > - unused-direct-shlib-dependency > This can be usually ignored. well. > - undefined-non-weak-symbol > @ As this has -devel package and linkage is done for the libraries > in -devel package, this cannot be ignored. > Perhaps linkage against libm.so is missing. gone. (at last not appear for me) > > * Compiler flags > - Well, would you explain a bit more in detail what happens with > "-Wp,-D_FORTIFY_SOURCE=2" (on this bug)? > And is it not-so-easy problem to fix? Ugh, some plugins will simply crash with stack overflow error. In fact i need to investigate all places where this occur. It render unusable grass for now if i dont warkaround that flag. > > * Desktop file > - Category "Application" is deprecated and should be removed. removed. > * Documentation total size > - Well, I wonder if -doc subpackage should be created for grass > because the documentation included in main packages seems a bit > large in total.. Grass will render unusable if docs are not included. There are tons of buttons and hints wich use thos html references. If its really needed i can split into -docs, but mandatory dep of grass over -docs would be than. > * Documentation > - I think the following documentations should be added > ---------------------------------------------------------- > CHANGES - to main > ChangeLog_6.2.1.gz - to -devel > TODO - to devel > ----------------------------------------------------------- added. > * License > - Well, just a question, what are the following files? > ---------------------------------------------------------- > ./lib/gis/datum.table > ./lib/gis/datumtransform.table > ---------------------------------------------------------- Well, its a list of some constants/parameters used for transformation between geographical projections, as i see its done by grass team. I wonder what is so illegal over it since those transforms are documented in hundred thousand of books and places ... Every geograph/topo stuff should know about elipsoid projection or whatsoever kind of non-cartesian projections .... In fact i wonder who was first, patent-camera or e.g Gauss or Krasovsky ... ;-) Basicaly are constant numbers like PI in math ... If need i remove tham, but i see that in fact the grass team did those tables for their own, or maybe clarify origin ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review