https://bugzilla.redhat.com/show_bug.cgi?id=979124 --- Comment #5 from Erik Schilling <ablu.erikschilling@xxxxxxxxxxxxxx> --- Ok I did those changes now: - Tried to make the summary of the main package better - Splitted the ui part in order to prevent depedency on ui libs for the core packages - Fixed ownership of the plugins (they are now actually owned by their subpackages) - Fixed ownership of some directories - Moved %%doc to the main package - Made the requirement of the base package arch-specific - Fixed html doc installation - Made the doc package noarch I splitted the ui executable into a seperate package to prevent having QtGui in the main one. So now only the cpp subpackage does not require any additional packages. However i wonder whether this really makes sense... In the future there will come more modules for different languages. I think it would be more consistent to have all of those modules as subpackage instead of having some included and some not. But well I am open for suggestions here. I also asked about the lgpl exception on the maillinglist (CC'd you). I hope I caught all unowned directories (is there some kind of tool to help checking for this?). Otherwise I think I fixed all the issues you mentioned. Regards and thanks a lot for your comments, Erik Updated SPEC file: http://ablu.fedorapeople.org/qbs.spec New SRPM file: http://ablu.fedorapeople.org/qbs-1.0.1-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sd9naPAQMm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review