[Bug 957815] Review Request: edg-mkgridmap - tool to build the grid map-file from VO servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=957815

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |RAWHIDE

--- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> %dir %{_libexecdir}/edg-mkgridmap
> %{_libexecdir}/edg-mkgridmap
> %{_libexecdir}/edg-mkgridmap/edg-mkgridmap.pl

https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

There's some confusion in this %files section.
If 

  %{_libexecdir}/edg-mkgridmap

is a directory, the %files entry

  %{_libexecdir}/edg-mkgridmap

includes the directory (as %dir) *and* everything in it, i.e. the entire tree
of files and directories with proper %dir attributes where necessary.

So, instead of the three lines as present, you either want

  %dir %{_libexecdir}/edg-mkgridmap
  %{_libexecdir}/edg-mkgridmap/edg-mkgridmap.pl

to be explicit about dir ownership and the Perl script.
Or just

  %{_libexecdir}/edg-mkgridmap/

to include the full directory tree. The trailing slash is optional, but
increases spec file readability (by making more clear that it's a dir).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tcjx5Hy0HI&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]