https://bugzilla.redhat.com/show_bug.cgi?id=927374 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- A few comments from my side. * %{gem_extdir_mri} is available in older Fedoras - You dont have to branch the %install and %files sections, since %{gem_extdir_mri} macro is supported by older Fedoras. * Ship lib/rugged/rugged.so instead of ext/rugged/rugged.so - If you read the guidelines properly, it exactly specifies, that you should move lib/rugged/rugged.so into %{gem_extdir_mri}. - This should fix also the wrong file permissions IMO, so you could remove the chmod. - This would render the: rm -rf %{buildroot}%{gem_instdir}/lib/rugged/rugged.so unnecessary as well. (In reply to Axilleas Pipinellis from comment #3) > Copying rugged.so from /usr/lib64 back to /usr/share, fixed it. I also > confirmed that it plays fine even with the .so in /usr/lib64 removed. In > conclusion, it only needs the one in /usr/share. Sorry, that is wrong conclusion for several reasons: * .so file is platform dependent and cannot end up in /usr/share what so ever * moving of .so file into /usr/share works, since the path is already available in Ruby's search path. That does not make it correct. * The problem is hidden in: mkdir -p %{buildroot}%{gem_extdir_mri}/lib/%{name}/ mv %{buildroot}%{gem_instdir}/ext/rugged/rugged.so \ %{buildroot}%{gem_extdir_mri}/lib/%{name}/ where %{name} should be replaced with %{gem_name}. I did not tested this change, but this is creates "/usr/lib/gems/ruby/rugged-0.16.0/lib/rubygem-rugged/", which is apparently wrong. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XQDH0zmWkC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review