[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=980960

--- Comment #3 from Ed Santiago <santiago@xxxxxxxxxx> ---
Many, many thanks. I believe I've addressed each issue you brought up.

Diffs:
https://git.fedorahosted.org/cgit/rpmgrill.git/commit/?id=0d77b8b89517aa150ec8b995389661a711107d48

New spec: http://www.edsantiago.com/f/rpmgrill.spec
New srpm: http://www.edsantiago.com/f/rpmgrill-0.22-1.fc17.src.rpm

New koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5570468

Clarifying note: The requirement on perl(IO::Socket::SSL) was hand-specified
because it's dynamically tested for by LWP::UserAgent inside an eval, so RPM
couldn't autodetect it. I have removed the requirement from the specfile
because that code isn't actually used in this version of rpmgrill.

Again, thanks for your thorough and helpful review. You clarified some
packaging points I hadn't understood, and (blush) pointed out some that I
missed in my haste.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0x6tS2op4X&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]