Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: modello-1.0-0.a8.4jpp - Modello Data Model toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227087 mwringe@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|mwringe@xxxxxxxxxx |pcheung@xxxxxxxxxx ------- Additional Comments From mwringe@xxxxxxxxxx 2007-03-13 23:36 EST ------- (In reply to comment #5) > (In reply to comment #4) > > X license field matches the actual license. > > I can't find the license for this project, could you please point me to it? > > > > http://maven.apache.org/maven-1.x/plugins/modello/license.html > > > That seems to be the license for the modello plugin for maven, i took a look at > their files, and it should be MIT Style license. License changed to MIT > > > X verify source and patches (md5sum matches upstream, know what the patches do) > > - please put clear instructions on how to generate the the source drop, the > > svn export command doesn't work > > > Hmm.. don't know why it wasn't working before. Sorry about that. > > > The svn export command works for me. > > > > X rpmlint on <this package>.srpm gives no output > > W: modello non-standard-group Development/Java - this is ok > > W: modello unversioned-explicit-provides modello-maven-plugin -please fix > > W: modello mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 36) -please fix Fixed > > > > When I fixed the mixed-use-of-spaces-and-tabs warning, the > > unversioned-explicit-provides warning disappeared. Perhaps you could double > > check this? > I'm still getting all the warnings, could you please double check as well? I > tried both spec file by installing the rpm or just downloading the one from your > url. > > > > X specfile is legible > > - should have %define _with_gcj_support 1 at the top of the spec file, please > > get rid of %define _with_gcj_support 0 and %define gcj_support 0, and the > > %define gcj_support .... doesn't seems like it can be split up into multiple > > lines > > > > When I do this, I am no longer able to build: > > java-gcj-compat-devel is needed by modello-1.0-0.1.a8.4jpp.1.i38 > > > Let's find a machine that you can build this on. The gcj issues should be now gone > > X make sure lines are <= 80 characters > > There are a couple of lines that are > 80, please fix those if possible. > > > > I fixed most of them. The ones that I didn't, were causing build errors. The less than 80 characters restriction is only for the description. You do not need to make all lines less than 80 characters. > > > Another thing is we'll need a without_maven option for this since this is a > dependency for maven This package does not need to be converted to ant, maven has it as part of its bootstrapping. https://mwringe.108.redhat.com/files/documents/175/299/modello.spec https://mwringe.108.redhat.com/files/documents/175/300/modello-1.0-0.1.a8.4jpp.2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review