[Bug 979663] Review Request: perl-CPAN-FindDependencies - Find dependencies for modules on CPAN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979663

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade@xxxxxxxxx

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f20

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     :
2dfca4970f7e30e4e3fdb403bdad42b6afa32cf3bd4b7827ff6bf0d80c917494
upstream tarball :
2dfca4970f7e30e4e3fdb403bdad42b6afa32cf3bd4b7827ff6bf0d80c917494

- License "GPL+ or Artistic" is not exactly valild

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=8, Tests=23, 34 wallclock secs ( 0.05 usr  0.01 sys +  8.30 cusr  0.31
csys =  8.67 CPU)

+ This package perl-CPAN-FindDependencies-2.42-1.fc20.noarch
Provides: perl(CPAN::FindDependencies) = 2.42
perl(CPAN::FindDependencies::Dependency) = 2.1
perl(CPAN::FindDependencies::MakeMaker) = 0.3 perl-CPAN-FindDependencies =
2.42-1.fc20

Requires: /usr/bin/perl perl(CPAN::FindDependencies::Dependency)
perl(CPAN::FindDependencies::MakeMaker) perl(Capture::Tiny) perl(Config)
perl(Cwd) perl(Exporter) perl(File::Temp) perl(LWP::UserAgent)
perl(Module::CoreList) perl(Parse::CPAN::Packages) perl(Scalar::Util)
perl(YAML::Tiny) perl(constant) perl(strict) perl(vars)

suggestions:
1) Like suggested in other reviews, we don't need to list explicitly Requires.
Also, package should not be hard versioned dependent.

2) License should be "GPLv2+ or Artistic"

3) You may want to add following for skipped test
BuildRequires: perl(Test::Pod::Coverage)

Note: Its not mandatory to add above BR: its just suggestion like given in
other package reviews of me. See more
https://fedoraproject.org/wiki/Packaging:Perl#When_to_.2Anot.2A_test

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WiE1VbhTYb&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]