https://bugzilla.redhat.com/show_bug.cgi?id=979661 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f20 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball : bb8c499a3a663aa0495e8892ebd10ddc3549be8e742976014d7fb885eb278ff7 upstream tarball : bb8c499a3a663aa0495e8892ebd10ddc3549be8e742976014d7fb885eb278ff7 + License "GPLv2+ or Artistic" is valid and included in source files. + rest follows packaging guidelines + make test is successful with output All tests successful. Files=5, Tests=69, 271 wallclock secs ( 0.04 usr 0.00 sys + 2.19 cusr 0.29 csys = 2.52 CPU) + This package perl-Net-Random-2.22-1.fc20 Provides: perl(Net::Random) = 2.22 perl-Net-Random = 2.22-1.fc20 Requires: perl(Data::Dumper) perl(JSON) perl(LWP::UserAgent) perl(Sys::Hostname) perl(strict) perl(vars) suggestions: 1) Though all the tests that run are successful, I see one test got skipped due to missing BuildRequires: perl(Test::Pod::Coverage) add this to spec file 2) Remove explicitly listed Requires: from spec file as rpm should find those dependencies while installing this package. Only when rpm fails to find we need to list it explicitly. Requires: perl(Encode::Locale) >= 1.01 Requires: perl(JSON) Requires: perl(LWP::UserAgent) Requires: perl(Test::MockObject) >= 1.07 Requires: perl(Test::More) >= 0.64 3) Also, don't add hard versioned requirement in BuildRequires or Requires. so your BuildRequires should be BuildRequires: perl(Encode::Locale) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(JSON) BuildRequires: perl(LWP::UserAgent) BuildRequires: perl(Test::MockObject) BuildRequires: perl(Test::More) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WDRFjvSMRA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review