https://bugzilla.redhat.com/show_bug.cgi?id=979673 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f20 - rpmlint on rpms gave perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree perl(Getopt::Long) perl-File-Find-Object.noarch: W: doc-file-dependency /usr/share/doc/perl-File-Find-Object-0.2.7/examples/tree /usr/bin/perl 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7 upstream tarball : 403e8b7062fff32785ac722f3fe56b32c3641ee219d719f2e762ff441215aed7 - License "GPL+ or Artistic" is not exactly valid. - make test is successful with output looks all test successful but some got skipped + This package Provides: perl(File::Find::Object) = 0.2.7 perl(File::Find::Object::Base) perl(File::Find::Object::DeepPath) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Find::Object::TopPath) perl-File-Find-Object = 0.2.7-1.fc20 Requires: /usr/bin/perl perl(Carp) perl(Fcntl) perl(File::Find::Object) perl(File::Find::Object::Base) perl(File::Find::Object::PathComp) perl(File::Find::Object::Result) perl(File::Spec) perl(Getopt::Long) perl(List::Util) perl(base) perl(integer) perl(strict) perl(warnings) suggestions: 1) rpm can automatically find required packages for perl packages so don't need to explicitly mention following in spec file. Please remove it. Requires: perl(Carp) Requires: perl(Class::XSAccessor) Requires: perl(File::Spec) Requires: perl(List::Util) 2) From README and source files, its clear that license tag should be "GPLv2+ or Artistic" 3) Add following for executing all the tests BuildRequires: perl(Test::Pod::Coverage) BuildRequires: perl(Test::Pod) #BuildRequires: perl(Test::TrailingSpace) I see perl-Test-TrailingSpace is not available in Fedora. Though its not mandatory but good if you can package it also. http://search.cpan.org/dist/Test-TrailingSpace/ 4) rpmlint warning doc-file-dependency can be fixed by adding following in %prep chmod 644 examples/tree -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IWwvMhBmui&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review