[Bug 979653] Review Request: perl-Perl6-Slurp - Implemention of the Perl 6 'slurp' built-in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979653

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ mock build is successful for f20

+ rpmlint on rpms gave
perl-Perl6-Slurp.noarch: W: spelling-error Summary(en_US) Implemention ->
Implement ion, Implement-ion, Implementation
perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US filename ->
file name, file-name, filament
perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US filehandle ->
file handle, file-handle, mishandle
perl-Perl6-Slurp.noarch: W: spelling-error %description -l en_US typeglob ->
type glob, type-glob, logotype
perl-Perl6-Slurp.src: W: spelling-error Summary(en_US) Implemention ->
Implement ion, Implement-ion, Implementation
perl-Perl6-Slurp.src: W: spelling-error %description -l en_US filename -> file
name, file-name, filament
perl-Perl6-Slurp.src: W: spelling-error %description -l en_US filehandle ->
file handle, file-handle, mishandle
perl-Perl6-Slurp.src: W: spelling-error %description -l en_US typeglob -> type
glob, type-glob, logotype
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
==> Ignore this

+ Source verified with upstream as (sha256sum)
srpm tarball: 49fdcbb37b7a0fd1bf043970cfe42913080b1e3bf794a03b103c14480d48d60a
upstream tarball:
49fdcbb37b7a0fd1bf043970cfe42913080b1e3bf794a03b103c14480d48d60a

- License "Freely redistributable without restriction" looks invalid.

+ rest follows packaging guidelines

+ make test is successful with output
All tests successful.
Files=13, Tests=183,  1 wallclock secs ( 0.06 usr  0.01 sys +  0.26 cusr  0.03
csys =  0.36 CPU)

+ This package
Provides: perl(Perl6::Slurp) = 0.051003 perl-Perl6-Slurp = 0.051003-1.fc20
Requires: perl >= 0:5.008 perl(Carp) perl(Scalar::Util) perl(strict)
perl(warnings)

suggestions:
1)Look https://fedoraproject.org/wiki/Packaging:Perl#License_tag and you will
see license for this package is "GPL+ or Artistic"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NxC5ljMveN&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]