https://bugzilla.redhat.com/show_bug.cgi?id=658754 --- Comment #22 from Christopher Meng <cickumqt@xxxxxxxxx> --- I provide some review of spec: 1. Please, do not use %define, Fedora now recommends %global instead of %define. 2. Please, don't define the Release tag like "%{release}%{?dist}", just replace it with 1%{?dist} is easy, right? You use about 30 chars space to define a macro of "1", jesus.. 3. And for the Group tag, you can safely drop them. 4. I noticed that you have some systemd macros, but the judge is for f15, and please update.(I think you don't need to care about fedora 15 now. You can at least push it to f19 now.) Ref: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 5. I can see autogen, so please double check the Requires, I guess this might not be built under mock 6. No need for rm -rf %{buildroot} in %install section 7. install should be with -p to preserve the timestamp. 8. Why %preun and %postun of -devel package have "-p /sbin/ldconfig"? Duplicated? 9. I think you don't need to remove the cubrid user when removing. mariadb and postgresql and many others don't do that. 10. As I've said before, cleanup the chkconfig and if else things. 11. No need to rm -rf %{buildroot} in %clean section.(RPM supports it since long time ago, please change your habit) 12. No need to %defattr(-,root,root,-) (RPM supports it since long time ago, please change your habit) And: %defattr(-,cubrid,cubrid,-) %config(noreplace) %{_sysconfdir}/cubrid %{cubridsharedata}/conf %{cubridsharedata}/databases %{cubridsharedata}/log %{cubridsharedata}/tmp %{cubridsharedata}/var If you want to define your attributes, please use attr() in front of every file you want to specify. 13. No need to keep BuildRoot tag(RPM supports it since long time ago, please change your habit) 14. openjdk has 1.8 version now, please test. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fA5NKRg3TB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review