[Bug 978743] Review Request: superkb - Graphical application launcher for Linux.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=978743

--- Comment #15 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #14)
> > %{_mandir}/man1/superkb.1.gz
> > %attr(0644, root, root)  %{_mandir}/man1/superkb.1.*
> 
> That's a duplicate entry. Either line would have been enough.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files
> 
> Reduce usage of %attr to files with really special ownership and
> permissions, such as non-root user/group and setuid. If the man page isn't
> mode 0644, preferably fix it up in %install section and in the upstream
> tarball.

It's true, Michael. It was late at night and I didn't see the error. sorry for
that.

@biker, please fix it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cf4C139yyb&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]