https://bugzilla.redhat.com/show_bug.cgi?id=927374 --- Comment #1 from Axilleas Pipinellis <axilleas@xxxxxxxxxxxx> --- Hi, this is my first informal review as I am yet to be sponsored as a packager :) Followed by the discussion in Ruby-SIG[0], I am posting both those questions answered and some other details that need fixing. * explicit-lib-dependency libgit2 - libgit2 is bundled in the gem, it should be removed. * non-standard-executable-perm /usr/lib64/gems/ruby/rugged-0.16.0/lib/rubygem-rugged/rugged.so 0775L - Permissions should be 755. * Duplicate sonames (arch-dependent-file-in-usr-share) - /usr/share/gems/gems/rugged-0.16.0/lib/rugged/rugged.so should not be there. * Mixed use of macros - Use either %{buildroot} or $RPM_BUILD_ROOT, not both. * Test suite - Since this package provides a test suite it would be nice to run it. Here is a patch that builds fine (download here [1]): ------------------------------------ diff -rupN a/rubygem-rugged.spec b/rubygem-rugged.spec --- a/rubygem-rugged.spec 2013-03-25 20:42:26.000000000 +0200 +++ b/rubygem-rugged.spec 2013-06-24 22:27:23.840000000 +0300 @@ -17,9 +17,10 @@ BuildRequires: ruby(release) Requires: ruby(abi) BuildRequires: ruby(abi) %endif -BuildRequires: zlib-devel -BuildRequires: ruby-devel -BuildRequires: rubygems-devel +BuildRequires: zlib-devel +BuildRequires: ruby-devel +BuildRequires: rubygem(minitest) +BuildRequires: rubygems-devel Provides: rubygem(%{gem_name}) = %{version} %description @@ -73,6 +74,17 @@ mv %{buildroot}%{gem_instdir}/ext/rugged rm -rf $RPM_BUILD_ROOT%{gem_instdir}/{.require_paths,.gitignore,.travis.yml,.yardoc} rm -rf $RPM_BUILD_ROOT%{gem_instdir}/ext/ +%check + +pushd .%{gem_instdir} + +## Fix failing test: https://github.com/libgit2/rugged/pull/65 +sed -i '78s/.*/now = Time.at Time.now.to_i/' test/index_test.rb + +find test -type f -name *_test.rb | xargs testrb -Ilib + +popd + %files %doc %{gem_instdir}/LICENSE %doc %{gem_instdir}/README.md ----------------------------------- [0] https://lists.fedoraproject.org/pipermail/ruby-sig/2013-July/001373.html [1] http://axilleas.fedorapeople.org/tmp/rubygem-rugged.spec.patch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sM2n15yYhB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review