https://bugzilla.redhat.com/show_bug.cgi?id=980399 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- $ licensecheck -r * ntplib.py: LGPL (v2 or later) (with incorrect FSF address) setup.py: *No copyright* UNKNOWN test_ntplib.py: *No copyright* UNKNOWN The file ntplib.py is that file which we refer to as the software we want to package. Don't bother with ambiguous license files. The header in ntplib.py and PKGINFO say LGPL or later versions, so the license tag is LGPLv2+. Moreover, the CHANGELOG contains this: version 0.1.8 - 2010-02-20 - change to LGPL license - cleanup Is it possible to run test_ntplib.py in a %check section? Would this make sense? rm -rf $RPM_BUILD_ROOT is an artifact from older Fedora releases. Don't know why rpmdev-newspec still adds it to a spec file. You can safely drop that line. You have to add CHANGELOG and COPYING.LESSER to %doc. BTW, the incorrect FSF address in ntplib.py is worth to be reported upstream. One of the description lines is too long, line 16 has 81 characters. Should be no more than 80. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kAtcRp8rQv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review