https://bugzilla.redhat.com/show_bug.cgi?id=979648 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: 1b654cb4416242f1433a69603178a9ac9bf3bac0f83f00d7e479c6801607a22d) Ok. Summary verified from lib/Tapper.pm. Ok. Description verified from lib/Tapper.pm. Ok. License verified from README, LICENSE, lib/Tapper.pm. FIX: Use `BSD' as license tag value. See <https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses> for normative license names. No XS code, noarch BuildArch is Ok. TODO: You can replace `%{__perl}' macros with plain `perl' command. TODO: You can replace PERL_INSTALL_ROOT argument name with DESTDIR in %install section. TODO: You do not need to remove empty directories in %install section. Modern ExtUtils::MakeMaker does not produces ones. TODO: Build-require `perl' because you call at at various places in the spec file. TODO: Build-require `perl(strict)' (Makefile.PL:2). TODO: Build-requier `perl(warnings)' (Makefile.PL:3). TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with version `>= 6.30' (Makefile.PL:7). FIX: Build-require `perl(Test::More)' (t/release-eol.t:4). All tests pass. Ok. $ rpmlint perl-Tapper.spec ../SRPMS/perl-Tapper-4.1.1-1.fc20.src.rpm ../RPMS/noarch/perl-Tapper-4.1.1-1.fc20.noarch.rpm perl-Tapper.src: W: invalid-license 2-clause BSD perl-Tapper.noarch: W: invalid-license 2-clause BSD 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: Correct the license name. $ rpm -q -lv -p ../RPMS/noarch/perl-Tapper-4.1.1-1.fc20.noarch.rpm drwxr-xr-x 2 root root 0 Jul 2 09:07 /usr/share/doc/perl-Tapper-4.1.1 -rw-r--r-- 1 root root 3424 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/Changes -rw-r--r-- 1 root root 4524 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/Changes-3.0.md -rw-r--r-- 1 root root 2489 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/Changes-4.0.md -rw-r--r-- 1 root root 821 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/Changes-4.1.md -rw-r--r-- 1 root root 1316 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/LICENSE -rw-r--r-- 1 root root 7726 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/META.json -rw-r--r-- 1 root root 255 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/README -rw-r--r-- 1 root root 2182 Nov 19 2012 /usr/share/doc/perl-Tapper-4.1.1/Starterpage.md -rw-r--r-- 1 root root 2958 Jul 2 09:07 /usr/share/man/man3/Tapper.3pm.gz -rw-r--r-- 1 root root 2347 Nov 19 2012 /usr/share/perl5/vendor_perl/Tapper.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Tapper-4.1.1-1.fc20.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.16.3) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Tapper-4.1.1-1.fc20.noarch.rpm | sort | uniq -c 1 perl(Tapper) = 4.1.1 1 perl-Tapper = 4.1.1-1.fc20 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Tapper-4.1.1-1.fc20.noarch.rpm Binary dependencies resolvable. Ok. Package does not build in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5564364). FIX: Build-require `perl(Test::More)'. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ju7DeTKcC4&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review