https://bugzilla.redhat.com/show_bug.cgi?id=980071 --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Initial look into your spec(only spec, SRPM will later after your changes): First of all, IMO please cleanup the spec changelog, I know you just copied and edited something, but, I think no need to keep the copyright because you have to change a lot of things still. 1. If you %global src_name xpyb, I think in Source0/%prep/%build you should replace it. Or just drop this %global, you can see that xpyb is only 4 chars, src_name is 8; And you've defined the macro but you don't use it everywhere. 2. I think you can drop Group tag, as Fedora doesn't think it's important now.(optional) 3. Summary tag should be changed to "Python bindings to XCB". This is really simple and you can see that other distros also use it(simple but strong) 4. Why did you keep the %defattr, which is obsoleted from RPM 4.4? 5. subpackage naming should be simple, %package -n python-xpyb-devel %description -n python-xpyb-devel can be replaced by %package devel %description devel 6. Requires: python-xpyb == %{version} is incorrect IMO, we always use: Requires: %{name} = %{version}-%{release} 7. You are not packaging the latest version. http://xcb.freedesktop.org/dist/xpyb-1.3.1.tar.bz2 is the latest. 8. %description: "The Python binding requires libxcb.so to work. The additional extension libraries are not required." Ah..Do you think we need this? So, as a summary, please rewrite the spec :D -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JDjlzMquBb&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review