Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: tclx https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226480 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-03-13 20:42 EST ------- * The call to autoconf shouldn't be needed. If you want to restore the configure timestamp, you can do touch -r configure.2.relid configure but I don't think that it is needed. * The RPM_OPT_FLAGS are overwritten. I suggest using make all CFLAGS_DEFAULT= CFLAGS_WARNING= but maybe there are cleaner ways. * could you please expand on: # utf-8 locale needed to avoid truncating help files LANG=en_US.UTF-8 make install DESTDIR=$RPM_BUILD_ROOT * the ldconfig call seems completly unuseful to me: there is no library that can be linked against. * the documentation on using tclx is lacking. There is a README with instructions, but it refers to a man page that isn't bundled (TclX_Init.3). Looking at that man page it seems to refer to a library that isn't bundled?? * Related issue is should the man pages in doc/ be installed? * is the header file of any use without lib to link against? * why is tix mentioned in the -devel description? * Did you have a look at the tcl draft guideline? http://fedoraproject.org/wiki/PackagingDrafts/Tcl It may not be final, but maybe there are already things to use? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review