https://bugzilla.redhat.com/show_bug.cgi?id=911060 --- Comment #8 from Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> --- (In reply to Marcelo Barbosa from comment #7) > I suggest also alter spec file inserting this option: > > %global pkgname winston > > And change all spec file for new variable %{pkgname} removing name > "winston" Thanks Marcelo (and thanks very much for the other reviews you've done so far!). Using pkgname variable can be convenient, but I find that SPEC files are generally more readable without it. I've always preferred readability over convenience. Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-winston.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-winston-0.7.2-1.fc19.src.rpm * Mon Jul 01 2013 Jamie Nguyen <jamielinux@xxxxxxxxxxxxxxxxx> - 0.7.2-1 - update to upstream release 0.7.2 - fix spelling in %%summary -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0oLjEDDnQw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review