https://bugzilla.redhat.com/show_bug.cgi?id=979767 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Christopher Meng from comment #1) > I'd like to say the author is good at making money. It's perfectly acceptable for foss developers to request donations :) > > However some problems: > > 1. Source0 can be found: http://gottcode.org/kapow/kapow-1.4.4.1-src.tar.bz2 Updated > > 2. Please leave less blank lines as far as possible. > > 3. No need to rm -rf $RPM_BUILD_ROOT > > 4. desktop-file-validate should be put into %check section. This is not a MUST. The guidelines say that desktop-file-validate can be used in either the install or check sections. I've moved it to a separate check section now any way. http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Spec/f19 srpm updated. Since they are only cosmetic changes, I haven't rebuilt the binary rpms. I notice you haven't accepted the review ticket. Are you going to do a full review? :) Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rAPbEQMlIn&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review