[Bug 979738] Review Request: crawl-sdl - free roguelike game of exploration and treasure-hunting in dungeons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979738

--- Comment #2 from Volker Fröhlich <volker27@xxxxxx> ---
Why did you pick "crawl-sdl" as the name?
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming

Please provide the files under some URL easy to use with wget or curl.

Remove the BRs listed under
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Remove the Requires that are not fonts:
http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

Use -p on cp to preserve the original timestamps.

You should use the version macro in your %setup invocation.

Most people leave a blank line between changelog entries. I think you should
also wrap the lines at some point.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UTJOFlQuca&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]