[Bug 977638] Review Request: python-espeak - Python bindings for espeak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=977638

--- Comment #5 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi @Eduardo
about this lines.
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
are used only for el5 packages, since Fedora 13 or greater this macro can be
defined for you, so as you has used it in your spec.

You can test with that, open a terminal and invoke the python interpreter,
$ python

Python 2.7.5 (default, May 16 2013, 13:44:12) 
[GCC 4.8.0 20130412 (Red Hat 4.8.0-2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from distutils.sysconfig import get_python_lib; print(get_python_lib(1))
/usr/lib64/python2.7/site-packages
>>> 

now, check the out of this rpm macro 
 rpm -E %{python_sitearch}
/usr/lib64/python2.7/site-packages

do you see that why don't is necessary repeat it?

for more information, please see:
https://fedoraproject.org/wiki/Packaging:Python#Macros

Buildroot isn't necessary for fedora packages, only for el5 packages, also you
could want to test the package against python2.4 in el5(the default version
installed). if this package is relatively new maybe don't works in that
version.

Obviously you can ship the package for el6, in this moment the el6's packaging
guidelines not differ from Fedora

BuildRequires:  gcc-c++
this BR is implicit, are considered part of the minimum build environment
see: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

%defattr(-,root,root) isn't needed

rpmlint output: 
python-espeak.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/espeak/core.so 0775L
please fix it

A question, What is the need of using fdupe?

Cheers -

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09bV0bqFy6&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]