https://bugzilla.redhat.com/show_bug.cgi?id=979124 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Brief look at the spec file and automated Plague/Mock build attempt for dist-f19: > Summary: Qt Build Suite This is the name of the software and not a helpful summary: https://fedoraproject.org/wiki/Examples_of_good_package_summaries > License: LGPLv2 with exceptions How much has this been reviewed already? https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses | Please be sure that any exceptions are approved by emailing them | to legal@xxxxxxxxxxxxxxxxxxxxxxx first. It's also less than ideal to include the license terms only in the optional -doc package instead of the base package. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing * https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package * https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories > -rw-rw-r--. 1 root root 653400 Jun 29 13:59 qbs-1.0.1-1.fc19.x86_64.rpm > -rw-rw-r--. 1 root root 21044 Jun 29 13:59 qbs-cpp-1.0.1-1.fc19.x86_64.rpm > -rw-rw-r--. 1 root root 5718148 Jun 29 13:59 qbs-debuginfo-1.0.1-1.fc19.x86_64.rpm > -rw-rw-r--. 1 root root 11548 Jun 29 13:59 qbs-devel-1.0.1-1.fc19.x86_64.rpm > -rw-rw-r--. 1 root root 12700 Jun 29 13:59 qbs-doc-1.0.1-1.fc19.x86_64.rpm > -rw-rw-r--. 1 root root 62700 Jun 29 13:59 qbs-qt-1.0.1-1.fc19.x86_64.rpm A lot of fragmentation and tiny subpackages for no gain, IMO. Notice how the base package contains other parts for C++ and Qt support (e.g. plugins). This is somewhat half-hearted and certainly could be improved. The -cpp and -qt subpackages don't even add any dependencies. The -doc subpackage doesn't include the HTML documentation it advertizes. $ rpmls -p qbs-doc-1.0.1-1.fc19.x86_64.rpm drwxr-xr-x /usr/share/doc/qbs drwxr-xr-x /usr/share/doc/qbs-doc-1.0.1 -rw-r--r-- /usr/share/doc/qbs-doc-1.0.1/LGPL_EXCEPTION.txt -rw-r--r-- /usr/share/doc/qbs-doc-1.0.1/LICENSE.LGPL -rw-r--r-- /usr/share/doc/qbs-doc-1.0.1/README -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xfYWaPORzA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review