Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rhino-1.6-0.r2.2jpp - JavaScript for Java https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227113 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|pcheung@xxxxxxxxxx |mwringe@xxxxxxxxxx Flag|fedora-review? |fedora-review+ ------- Additional Comments From pcheung@xxxxxxxxxx 2007-03-13 17:25 EST ------- (In reply to comment #4) > > X license text included in package and marked with %doc > > No license marked with %doc > > No license is present in the upstream tarball. > OK > st) > > X specfile is legible > > - the ant command in %build has reference to xmlbeans/xbean, should that be get > > rid of? > > I kept it there on purpose so that we don't forget about it during next update.. > I will remove it if you still want me to though. > If you kept it there on purpose, that's fine than. > > > > X run rpmlint on the binary RPMs > > There are 2 errors: > > E: rhino-javadoc zero-length /usr/share/javadoc/rhino-1.6/package-list > > E: rhino-javadoc zero-length > > /usr/share/javadoc/rhino-1.6/org/mozilla/javascript/ContextFactory.Listener.html > > Are these auto-generated files? > > Yes, they are auto-generated and beyond packager control. > OK > Warnings about encoding are fixed. > Great. Thanks! > New spec and srpm: > http://people.redhat.com/dbhole/fedora/rhino/rhino.spec > http://people.redhat.com/dbhole/fedora/rhino/rhino-1.6-0.1.r5.1jpp.1.fc7.src.rpm > rpmlint on mock built rpms: [pcheung@to-fcjpp1 review]$ rpmlint /var/lib/mock/fedora-development-x86_64-core-pcheung/result/rhino-*rpm W: rhino non-standard-group Development/Libraries/Java W: rhino no-documentation W: rhino non-standard-group Development/Libraries/Java W: rhino-demo non-standard-group Development/Libraries/Java W: rhino-demo no-documentation W: rhino-javadoc non-standard-group Development/Documentation E: rhino-javadoc zero-length /usr/share/javadoc/rhino-1.6/package-list E: rhino-javadoc zero-length /usr/share/javadoc/rhino-1.6/org/mozilla/javascript/ContextFactory.Listener.html W: rhino-manual non-standard-group Development/Libraries/Java E: rhino-manual zero-length /usr/share/doc/rhino-manual-1.6/apidocs/org/mozilla/javascript/ContextFactory.Listener.html E: rhino-manual zero-length /usr/share/doc/rhino-manual-1.6/apidocs/package-list APPROVED. Reassigning for building in plague. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review