https://bugzilla.redhat.com/show_bug.cgi?id=978284 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Axilleas Pipinellis from comment #0) > (Although, it fails as it cannot open a netcat connection needed by one of > tests, will refer about this on devel) This can be workarounded by applying: sed -i "s/localhost/localhost4/" test/publish_subscribe_test.rb prior the test suite is executed. After discussion with ncat maintainer, we discovered, that the "localhost" resolves to IPv6 address, while Redis does not suppoer IPv6 yet [1]. You might want to try to propose this fix to upstream as well, until Redis is IPv6 ready. * rpmlint error - You should not include dot files in RPM, as is reported by rpmlint: rubygem-redis-doc.noarch: E: version-control-internal-file /usr/share/gems/gems/redis-3.0.4/test/db/.gitignore * Remove Requires: Redis - This is Redis client library. The server can run on Remote machine. Therefore Redis should not be runtime dependency of this package, until there will be some kind of soft dependencies supported by YUM/RPM Otherwise the package looks good. Please fix these two nits. [1] https://github.com/antirez/redis/pull/61 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ISvM1otDVB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review