Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jpgalleg - JPEG library for the Allegro game library Alias: jpgalleg https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227198 chris.stone@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag|fedora-review? |fedora-review+ ------- Additional Comments From chris.stone@xxxxxxxxx 2007-03-13 16:48 EST ------- ==== REVIEW GUIDELINES ==== - rpmlint output: W: jpgalleg-devel no-documentation W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_cx_r W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_cx_w W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_get_cpuid_info W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_is_486 W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_is_cpuid_supported W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_is_cyrix W: jpgalleg undefined-non-weak-symbol /usr/lib64/libjpgal.so.2.5 _i_is_fpu Okay, see comment #5 - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - licensed with open source compatible license - license field matches actual license - license text included in %doc - spec written in American english - spec legible - sources match upstream 4bdd12fc3c1afb06f4ec23b4cb200559 - successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - ldconfig called in %post/un sections - package is not relocatable - package owns all directories it creates - directories it does not owned belong to filesystem - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage is consistent - contains code - no large documentation - files in %doc do not affect runtime - header files located in devel subpackage - no static libraries - no pkgconfig files - .so file in devel subpackage - devel have fully versioned dependency - no libtool archive files - not a GUI application - package does not own files or directories owned by other packages *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review