[Bug 978010] Review Request: perl-Wx-GLCanvas - Interface to wxWidgets' OpenGL canvas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=978010

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
Ok, the deps are all wrong :)

What you actually need to BR:
perl, perl(Exporter), perl(lib), perl(strict), perl(Wx::build::MakeMaker), and
wxGTK-devel

ExtUtils::MakeMaker is only used if Wx::build::MakeMaker is not present.
Alien::wxWidgets and Wx are not required for build in your case.


I don't understand how the package builds without the wx/* files since they're
all included in GLCanvas.xs.  Could you explain that?  Also, why do you remove
the directory?


You'll need to buildrequire many more modules in the %{?with_tests} conditional
block:
perl(base), lib/Wx/GLCanvas.pm:17
perl(Test::More), t/zz_pod.t:4
perl(Wx), lib/Wx/GLCanvas.pm:16
perl(Wx::ScrolledWindow), lib/Wx/GLCanvas.pm:17

Protip: You could use Test::NeedsDisplay to provide an Xvfb display for the
tests, running them everywhere, every time.
https://metacpan.org/module/ADAMK/Test-NeedsDisplay-1.07/lib/Test/NeedsDisplay.pm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ui2w3IuAFI&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]