https://bugzilla.redhat.com/show_bug.cgi?id=855780 --- Comment #11 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Mikolaj Izdebski from comment #10) > > > %global bits %(rpm --eval %{__isa_bits} | sed 's/32//') > > #%%global libdir %%{_prefix}/lib%%{bits} > > That's not needed (see above). > > > # svn export http://svn.apache.org/repos/asf/directory/deceased/daemon/tags/daemon-parent-1.1.8/ apacheds-daemon-1.1.8 > > # rm -rf apacheds-daemon-1.1.8/plugin/src/main/resources/org/apache/directory/daemon/installers/* > > # find apacheds-daemon-1.1.8 -name '*.bat' -delete > > # find apacheds-daemon-1.1.8 -name '*.class' -delete > > # find apacheds-daemon-1.1.8 -name '*.dll' -delete > > # find apacheds-daemon-1.1.8 -name '*.exe' -delete > > # find apacheds-daemon-1.1.8 -name '*.jar' -type f -delete > > # find apacheds-daemon-1.1.8 -name '*.jnilib' -delete > > # find apacheds-daemon-1.1.8 -name 'jsvc_*' -delete > > # find apacheds-daemon-1.1.8 -name '*.so' -delete > > # find apacheds-daemon-1.1.8 -name 'wrapper-*' -type f -delete > > # tar czf apacheds-daemon-1.1.8-clean-src-svn.tar.gz apacheds-daemon-1.1.8 > > Source0: %{name}-%{version}-clean-src-svn.tar.gz > > To keep spec file simpler it would be better to create a separate shell > script (cleanup-tarball.sh) to do the cleaning. > > > Patch0: %{name}-%{version}-disable-izpack.patch > > I don't know what is the purpose of this patch. Every patch should have link > to upstream bug or a comment explaining its purpose. > > > BuildRequires: java-devel > > Not needed. ok removed > > sed -i 's|${version}|${project.version}|' pom.xml > > Is this necessary? Either explain why or provide link to upstream bug > tracker. > > > %pom_xpath_inject "pom:project/pom:reporting/pom:plugins/pom:plugin[pom:artifactId='maven-surefire-report-plugin']" " > > <version>any</version>" > the intent is to remove all warnings > I don't see why would you inject version "any" to the POM. Again, you need > to explain why you are doing this. > > > %pom_remove_dep tanukisoft:wrapper > > %pom_xpath_inject "pom:project/pom:dependencyManagement/pom:dependencies" ' > > <dependency> > > <groupId>tanukisoft</groupId> > > <artifactId>wrapper</artifactId> > > <version>any</version> > > <scope>system</scope> > > <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> > > </dependency>' > > %pom_xpath_inject "pom:project/pom:dependencies" ' > > <dependency> > > <groupId>tanukisoft</groupId> > > <artifactId>wrapper</artifactId> > > <version>any</version> > > <scope>system</scope> > > <systemPath>%{_prefix}/lib%{bits}/java-service-wrapper/wrapper.jar</systemPath> > > </dependency>' > > There is no need to use scope system with systemPath. Maven should be able > to locate all artifacts, also under /usr/lib. > java-service-wrapper don provides maven depmap or pom ... maven or xmvn work also without these file? > > %pom_remove_dep org.apache.maven:maven-project plugin > > %pom_add_dep org.apache.maven:maven-core plugin > > I understand why this was done (), but that > doesn't have to be obvious for everyone. Please add a comment. > ok done > > %pom_remove_dep plexus:plexus-utils plugin > > %pom_add_dep org.codehaus.plexus:plexus-utils plugin > > plexus:plexus-utils is available in Fedora. There is no need to replace it > with org.codehaus.plexus:plexus-utils. ok removed Spec URL: http://gil.fedorapeople.org/apacheds-daemon.spec SRPM URL: http://gil.fedorapeople.org/apacheds-daemon-1.1.8-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2bqxjQAZz8&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review