https://bugzilla.redhat.com/show_bug.cgi?id=977638 Marcin.Dulak@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Marcin.Dulak@xxxxxxxxx Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #2 from Marcin.Dulak@xxxxxxxxx --- Hi, some informal comments: - spec file from URL and SRPM differ - URL contains spurious characters: URL: https://launchpad.net/python-espeak‎; - use correct abbreviation: License: GPLv3 For a list see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses Project website states: GNU GPL v3 - i don't think BR: python-setuptools is needed? - R: espeak is needed. I don't see espeak on EPEL for el5, but i see it here: http://repos.jethrocarr.com/pub/amberdms/linux/centos/5/amberdms-os/SRPMS/ Maybe drop el5? - if we drop el5, so not needed anymore: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %defattr(-,root,root) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Siwfj9yIAO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review