https://bugzilla.redhat.com/show_bug.cgi?id=976886 Björn Esser <bjoern.esser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Björn Esser <bjoern.esser@xxxxxxxxx> --- (In reply to Marcin.Dulak from comment #10) > > You can use expansion here, instead of conditional: `%{?el5:--vendor "" \}` > > i got "unclosed macro or bad line continuation", so i use --vendor=="ase". Is a vendor tag really needed in a desktop-file? According to guidelines this should be ommited: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Desktop_files | --vendor and desktop-file-install | For F19 and onwards, do not apply a vendor tag to .desktop files (using | --vendor). New packages should not add a vendor tag to any older branches | either. The vendor tag is implemented by adding a vendor prefix to the | .desktop filename which breaks some tools. If an existing package has a | vendor tag in previous Fedora releases it must continue to do so but only in | those releases. This is mostly for the sake of user menu-editing which bases | off of .desktop file/path names and thus break if the filename changes. So just drop the "--vendor"-flag on SCM-import :) APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zyth9HNRVz&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review