https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser <bjoern.esser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #759803|0 |1 is obsolete| | --- Comment #14 from Björn Esser <bjoern.esser@xxxxxxxxx> --- Created attachment 764779 --> https://bugzilla.redhat.com/attachment.cgi?id=764779&action=edit improved spec-file Package looks fine, except minor issues inside spec: * BRs in spec-file should be rearranged/trimmed: %if 0%{?fedora} || 0%{?rhel} >= 7 BuildRequires: systemd %systemd_requires %else Requires(post): /sbin/chkconfig Requires(preun): /sbin/chkconfig Requires(preun): initscripts %endif BuildRequires: libtool, libjoedog-devel * no need for explicit requires remove Requires: libjoedog * Summary should not start with article Summary: Multi-threaded file watch utility * License-tag is incorrect: License: GPLv2+ and LGPLv2+ ##### hardening-check looks good: fido-1.0.7-4.fc20.x86_64.rpm/usr/sbin/fido: Position Independent Executable: yes Stack protected: yes Fortify Source functions: yes (some protected functions found) unprotected: gethostname unprotected: memset unprotected: snprintf unprotected: strcat unprotected: fgets unprotected: memmove unprotected: read unprotected: memcpy protected: strncpy protected: snprintf protected: vsprintf protected: memcpy protected: printf protected: fprintf protected: sprintf protected: syslog Read-only relocations: yes Immediate binding: yes ##### Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/bjoern.esser/fedora/review/972477-fido/licensecheck.txt ---> 's!License: GPLv2+!& and LGPLv2+!' [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). ---> no need for explicit requires [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fido-1.0.7-4.fc20.x86_64.rpm fido.x86_64: E: explicit-lib-dependency libjoedog fido.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti fido.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti fido.x86_64: W: only-non-binary-in-usr-lib fido.x86_64: E: incorrect-fsf-address /usr/share/doc/fido-1.0.7/COPYING 1 packages and 0 specfiles checked; 2 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint fido fido.x86_64: E: explicit-lib-dependency libjoedog fido.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti fido.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti fido.x86_64: W: only-non-binary-in-usr-lib fido.x86_64: E: incorrect-fsf-address /usr/share/doc/fido-1.0.7/COPYING 1 packages and 0 specfiles checked; 2 errors, 3 warnings. # echo 'rpmlint-done:' ---> please ask upstream to include a more recent revision of COPYING Requires -------- fido (rpmlib, GLIBC filtered): /bin/sh config(fido) libc.so.6()(64bit) libjoedog libjoedog.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) systemd Provides -------- fido: config(fido) fido fido(x86-64) Source checksums ---------------- http://www.joedog.org/pub/fido/fido-1.0.7.tar.gz : CHECKSUM(SHA256) this package : 27e9a01319066e190da91038f727a973c2ce43aa64d1fef8dd74996dcd4f568b CHECKSUM(SHA256) upstream package : de2b6389cdcad61c863ae32a6a36df96731d5bce9cba946e6801ebd5cfb219f5 However, diff -r shows no differences ---> Source0-tarball is pristine Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 972477 ##### Please fix the issues with spec-file and I'll grant review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ESJEENdGgq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review