Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: ed https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225717 ------- Additional Comments From tcallawa@xxxxxxxxxx 2007-03-13 15:36 EST ------- Why does ed BuildRequires: autoconf? I never see it invoked, and it doesn't need it to build. REVIEW ========= Blocker: BR: autoconf is not necessary Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Fix the one blocker and I'll approve this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review