https://bugzilla.redhat.com/show_bug.cgi?id=977446 --- Comment #8 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- (In reply to Matthew Booth from comment #6) > QUERIES > ======= > > It's a server, but it doesn't contain a systemd unit. Should it? Good question, but I think not. The reason is that you can't "just run" it without at least specifying a plugin and a file to serve, and even if you assume the default plugin should be 'file' it's not clear what file you would want to serve by default. > PROBLEMS > ======== > > I'm pretty sure the %changelog format should be: > * Mon Jun 24 2013 Richard W.M. Jones <rjones@xxxxxxxxxx> - 1.0.0-1 > (Note the additional '-', no idea why) Fixed. > Missing fully versioned dependency on -devel package: > Requires: %{name}%{?_isa} = %{version}-%{release} in nbdkit-devel I guess missing %{?_isa}? Fixed. > Example plugins are all packaged and installed, including: > nbdkit: /usr/lib64/nbdkit/plugins/nbdkit-example1-plugin.so > nbdkit: /usr/lib64/nbdkit/plugins/nbdkit-example2-plugin.so > nbdkit: /usr/lib64/nbdkit/plugins/nbdkit-example3-plugin.so Yup, that's intentional. > > REPORTED NON-PROBLEMS > ===================== > > Detected GPL (v2 or later) is a false positive on ltmail.sh Second version is here: Spec URL: http://oirase.annexia.org/reviews/nbdkit/nbdkit.spec SRPM URL: http://oirase.annexia.org/reviews/nbdkit/nbdkit-1.0.0-2.fc18.src.rpm Description: NBD server Fedora Account System Username: rjones -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QV3nx69rOt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review