Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: plexus-maven-plugin-1.2-2jpp - Plexus Maven plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227104 dbhole@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dbhole@xxxxxxxxxx |tbento@xxxxxxxxxx ------- Additional Comments From dbhole@xxxxxxxxxx 2007-03-13 15:01 EST ------- (In reply to comment #3) > > X * license field matches the actual license. > > License is MIT , not Apache Software License > > Fixed. > OK > > X * verify source and patches (md5sum matches upstream, know what the patches do) > > - if upstream doesn't release source drops, put *clear* instructions on > > how to generate the the source drop; ie. > > # svn export blah/tag blah > > # tar cjf blah-version-src.tar.bz2 blah > > > > The tarball creation command is incorrect. Should be: > > tar czf plexus-maven-plugin-src.tar.gz plexus-maven-plugin/ > > Fixed. > The tarball generation command is still incorrect.. > > X * rpmlint on <this package>.srpm gives no output > > - justify warnings if you think they shouldn't be there > > W: maven-jxr non-standard-group Development/Java > > W: maven-jxr no-documentation > > W: maven-jxr non-standard-group Development/Java > > W: maven-jxr mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 47) > > > > First 3 are OK. Last one needs fixing. > > Fixed. > OK > > X * BuildRequires are proper > > - builds in mock will flush out problems here > > See end. > > Fixed. > OK > > X * description expands upon summary (don't include installation > > instructions) > > > > Description should be changed to: > > > > Plexus Maven Plugin helps create plexus component descriptions from within > > Maven. > > Fixed. > OK > > X * config files should usually be marked with %config(noreplace) > > /etc/maven/fragments/plexus-maven-plugin is not a config file, and should > > not be marked as such. > > Fixed. > > This package has also been built on mock. However, plexus-appserver needed to > be fixed in order to build plexus-maven-plugin. This fix added plexus-xmlrpc and > xmlrpc as a %BuildRequires and as a %Requires. Since plexus-maven-plugin needs > to built on the jpackage stack, which does not have the fixed plexus-appserver > yet, plexus-xmlrpc and xmlrpc had to be manually installed inside the buildroot > > OK -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review