[Bug 976714] Review Request: python-sklearn - Machine learning in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=976714

--- Comment #2 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi @Sergio, 
- Why you naming the package as python-sklearn?
according to pypy the package is named scikit-learn
https://pypi.python.org/pypi/scikit-learn/
Please rename the package according to the upstream name

About BuildRequires:
python-devel is wrong, In Fedora is correct python2-devel or python3-devel
depending of the interpreter that is used
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

- You are filtering the privates so* however you are using the old method for
filter

I quote =>
http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
"As of rpm-4.9 (Fedora 15), rpm has a standard method to enable filtering. This
page documents that. EPEL5 and 6 do not have a recent enough version of rpm to
follow these guidelines. See EPEL:Packaging_Autoprovides_and_Requires_Filtering
if your package is to be built there as well." 

rm -rf %{buildroot} is not needed for latests versions of Fedora is only
necessary for el5

- explicit-lib-dependency python-matplotlib, rpm find the library dependencies
by itself. Do not put unneeded 
please see http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

the spec file that contains the SRPM differ of the spec publicated here

Diff spec file in url and in SRPM
---------------------------------
--- /home/makerpm/976714-python-sklearn/srpm/python-sklearn.spec       
2013-06-22 03:06:43.872642541 -0430
+++ /home/makerpm/976714-python-sklearn/srpm-unpacked/python-sklearn.spec      
2013-06-22 03:06:44.486655554 -0430
@@ -47,9 +47,10 @@

 %check
-%{__python} setup.py build_ext --inplace
+python setup.py build_ext --inplace
 nosetests sklearn/

 %files
 %doc examples/ AUTHORS.rst README.rst
+#%doc examples/ AUTHORS.rst README-py3k.rst README.rst
 %{python_sitearch}/sklearn
 %{python_sitearch}/scikit_learn-*.egg-info

- Please remove the bundle egg in %prep as well
# Remove bundled egg-info
rm -rf foo-info

- the package is arched, so you should do honors compilers flags

please see
➜  ~  rpm -E %{optflags}
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic

Best Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Cr3fhzQgKz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]