[Bug 927470] Review Request: python-genmsg - Python library for generating ROS message and service data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=927470

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
$ rpmlint -i -v *python-genmsg.src: I: checking
python-genmsg.src: I: checking-url http://ros.org/doc/api/genmsg/html/ (timeout
10 seconds)
python-genmsg.src: I: checking-url
https://github.com/ros/genmsg/archive/95ca00d77a6bad85b4719a25575862b964584f34/genmsg-0.3.10-95ca00d.tar.gz
(timeout 10 seconds)
python-genmsg.noarch: I: checking
python-genmsg.noarch: I: checking-url http://ros.org/doc/api/genmsg/html/
(timeout 10 seconds)
python-genmsg.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

python-genmsg-devel.noarch: I: checking
python-genmsg-devel.noarch: I: checking-url http://ros.org/doc/api/genmsg/html/
(timeout 10 seconds)
python-genmsg-devel.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

python-genmsg.spec: I: checking-url
https://github.com/ros/genmsg/archive/95ca00d77a6bad85b4719a25575862b964584f34/genmsg-0.3.10-95ca00d.tar.gz
(timeout 10 seconds)
3 packages and 1 specfiles checked; 0 errors, 2 warnings.


There's no documentation in your package. But the tarball contains the "doc"
subfolder with some useful info, please add it to the package.


Instead of repeating the summary in the description, you might use the
description from the project website:
"Project genmsg exists in order to decouple code generation from .msg & .srv
format files from the parsing of these files and from impementation details of
the build system (project directory layout, existence or nonexistence of
utilities like rospack, values of environment variables such as
ROS_PACKAGE_PATH): i.e. none of these are required to be set in any particular
way."


I take this for a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bzWh0JDig6&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]