Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: maven-jxr-1.0-2jpp - Maven JXR is a source cross referencing tool. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227081 tbento@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tbento@xxxxxxxxxx |dbhole@xxxxxxxxxx ------- Additional Comments From tbento@xxxxxxxxxx 2007-03-13 13:08 EST ------- > X * rpmlint on <this package>.srpm gives no output > - justify warnings if you think they shouldn't be there > W: maven-jxr non-standard-group Development/Java > W: maven-jxr no-documentation > W: maven-jxr non-standard-group Development/Java > W: maven-jxr mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 47) > > First 3 are OK. Last one should be fixed. Fixed. > X * summary should be a short and concise description of the package > These could use expanding, but nothing more is available on project side, so > OK. > > Would be nice to have summary be just: "Source cross referencing tool" > though Fixed. >Also, at the top of the spec file, change '%define _with_gcj_support 0' to: >%define _with_gcj_support 1 Fixed. >Sorry for so many updates.. just caught something in another package that >applies here too (missed because it'll happen only when built with maven): > >Change: >%if %{with_maven} >%if %{gcj_support} >%dir %attr(-,root,root) %{_libdir}/gcj/%{name} >%attr(-,root,root) %{_libdir}/gcj/%{name}/maven-jxr-1.0.jar.* >%endif > >to > >%if %{gcj_support} >%dir %attr(-,root,root) %{_libdir}/gcj/%{name} >%attr(-,root,root) %{_libdir}/gcj/%{name}/maven-jxr-1.0.jar.* >%endif >%if %{with_maven} Fixed. I've also built this package on mock. Here are the links to the updates spec file and source rpm: SPEC FILE: https://tbento.108.redhat.com/files/documents/177/256/maven-jxr.spec SOURCE RPM: https://tbento.108.redhat.com/files/documents/177/257/maven-jxr-1.0-2jpp.1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review