https://bugzilla.redhat.com/show_bug.cgi?id=971103 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #19 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi @Peter I haven't reviewed the package thoroughly, but I have a comments for you - The package has buildroot, for el6 it is not necessary, see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - Every time that you make changes to the spec, you should bump the release number - There are a weird requires in the retrieved requires from rpmbuild Requires (from fedora-review) -------- bsd-mailx (rpmlib, GLIBC filtered): /bin/sh /usr/sbin/alternatives config(bsd-mailx) Please see: http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering libbsd.so.0()(64bit) libbsd.so.0(LIBBSD_0.0)(64bit) libbsd.so.0(LIBBSD_0.2)(64bit) libc.so.6()(64bit) rtld(GNU_HASH) - A question, is bsd-mailx a fork of mailx.? I quote As a general rule, Fedora packages must NOT contain any usage of the Conflicts: field https://fedoraproject.org/wiki/Packaging:Conflicts Cheers Eduardo -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lvAZ0IgepJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review