[Bug 958059] Review Request: yum-axelget - A plugin for Yum based on Axel that accelerates your download's rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=958059

--- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Some "need to be fix":

1. Group/BuildRoot tag can be dropped.

2. BuildRequires:  python-devel should be BuildRequires:  python2-devel

3. Please change $RPM_BUILD_ROOT to %{buildroot}

4. No need to write rm -rf $RPM_BUILD_ROOT in %install; And no need for clean
section existed.

5. Why using this:

%{_usr}/lib/yum-plugins/

%{_usr} should be %{_prefix}, and for %{_usr}/lib, why not using:

6. Invalid changelog without version info.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lZujkFxD93&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]