https://bugzilla.redhat.com/show_bug.cgi?id=890771 --- Comment #7 from Michael Scherer <misc@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Large documentation must go in a -doc subpackage. Note: Documentation size is 19394560 bytes in 419 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - COPYING is installed twice when edge-utils is pulled in, no need to, so the main part of %doc on edge-utils can be dropped - some requires on -devel are redundant with automated Requires on pkgconfig, better drop them as this will be handled only rpm, so never out of date - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime, /usr/share/edje/examples, /usr/share/mime/packages, /usr/share/edje - Package should not use obsolete m4 macros, please warn upstream (not blocking) Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools - license tag is wrong, the epp binary is GPLv2, so this should be reflected in a comment ( breakdown of the license information ) - Test suite is not run, it seems there is a src/tests directory, so test should be run I guess - update-mime-database is invoked as required Note: mimeinfo files in: edje See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo - Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edje-utils ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated". 78 files have unknown license. Detailed output of licensecheck in /home/misc/checkout/git/FedoraReview/890771-edje/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/edje, /usr/share/edje/examples [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mime, /usr/share/edje/examples, /usr/share/mime/packages, /usr/share/edje [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. Note: Especially check following dirs for bundled code: /home/misc/checkout/git/FedoraReview/890771-edje/upstream- unpacked/Source0/edje-1.7.7/data/include [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: update-mime-database is invoked as required Note: mimeinfo files in: edje See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edje-utils [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 20346880 bytes in /usr/share 30720 edje-utils-1.7.7-1.fc20.x86_64.rpm 51200 edje-1.7.7-1.fc20.x86_64.rpm 20264960 edje-devel-1.7.7-1.fc20.x86_64.rpm See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.32 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.32 INFO: Mock Version: 1.1.32 Start: lock buildroot INFO: installing package(s): /home/misc/checkout/git/FedoraReview/890771-edje/results/edje-1.7.7-1.fc20.x86_64.rpm /home/misc/checkout/git/FedoraReview/890771-edje/results/edje-devel-1.7.7-1.fc20.x86_64.rpm /home/misc/checkout/git/FedoraReview/890771-edje/results/edje-utils-1.7.7-1.fc20.x86_64.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', 'install', '/home/misc/checkout/git/FedoraReview/890771-edje/results/edje-1.7.7-1.fc20.x86_64.rpm', '/home/misc/checkout/git/FedoraReview/890771-edje/results/edje-devel-1.7.7-1.fc20.x86_64.rpm', '/home/misc/checkout/git/FedoraReview/890771-edje/results/edje-utils-1.7.7-1.fc20.x86_64.rpm', '--setopt=tsflags=nocontexts'] Erreur : Paquet : edje-devel-1.7.7-1.fc20.x86_64 (/edje-devel-1.7.7-1.fc20.x86_64) Requiert : lua-devel < 5.2 Installé : lua-devel-5.2.2-1.fc20.x86_64 (@fedora) lua-devel = 5.2.2-1.fc20 Vous pouvez essayer d'utiliser --skip-broken pour contourner le problème Vous pouvez essayer d'exécuter : rpm -Va --nofiles --nodigest Rpmlint ------- Checking: edje-1.7.7-1.fc20.x86_64.rpm edje-devel-1.7.7-1.fc20.x86_64.rpm edje-utils-1.7.7-1.fc20.x86_64.rpm edje.x86_64: W: no-manual-page-for-binary edje_recc edje.x86_64: W: no-manual-page-for-binary edje_cc edje.x86_64: W: no-manual-page-for-binary edje_inspector edje.x86_64: W: no-manual-page-for-binary edje_decc edje.x86_64: W: no-manual-page-for-binary edje_player edje.x86_64: W: no-manual-page-for-binary edje_external_inspector edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/Edje.h.3.gz 4449: warning: macro `Swallows'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/Edje.h.3.gz 6269: warning: macro `emission'' not defined (possibly missing space after `em') edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/Edje.h.3.gz 6271: warning: macro `source'' not defined (possibly missing space after `so') edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/edje_text.c.3.gz 13: cannot use character `8' as a starting delimiter edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/edje_text.c.3.gz 40: cannot use character `8' as a starting delimiter edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 12: warning: macro `+'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 14: warning: macro `-'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 16: warning: macro `='' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 18: warning: macro `f'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 20: warning: macro `F'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 22: warning: macro `t'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 24: warning: macro `T'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 26: warning: macro `s'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 28: warning: macro `p'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 30: warning: macro `a'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/tutorial_edje_animations.3.gz 32: warning: macro `A'' not defined edje-devel.x86_64: W: manual-page-warning /usr/share/man/man3/edje_util.c.3.gz 2462: warning: macro `Swallows'' not defined edje-utils.x86_64: W: no-manual-page-for-binary inkscape2edc 3 packages and 0 specfiles checked; 0 errors, 24 warnings. Requires -------- edje (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libecore.so.1()(64bit) libecore_evas.so.1()(64bit) libecore_file.so.1()(64bit) libecore_imf.so.1()(64bit) libecore_imf_evas.so.1()(64bit) libecore_input.so.1()(64bit) libedje.so.1()(64bit) libeet.so.1()(64bit) libeina.so.1()(64bit) libembryo.so.1()(64bit) libevas.so.1()(64bit) liblua-5.2.so()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH) edje-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config ecore-devel edje(x86-64) eet-devel evas-devel libedje.so.1()(64bit) libeina-devel lua-devel pkgconfig pkgconfig(ecore) pkgconfig(ecore-evas) pkgconfig(ecore-imf) pkgconfig(ecore-imf-evas) pkgconfig(eet) pkgconfig(eina) pkgconfig(embryo) pkgconfig(evas) pkgconfig(lua) pth-devel zlib-devel edje-utils (rpmlib, GLIBC filtered): /usr/bin/env edje inkscape libc.so.6()(64bit) python rtld(GNU_HASH) Provides -------- edje: edje edje(x86-64) libedje.so.1()(64bit) edje-devel: edje-devel edje-devel(x86-64) pkgconfig(edje) edje-utils: edje-utils edje-utils(x86-64) Source checksums ---------------- http://download.enlightenment.org/releases/edje-1.7.7.tar.bz2 : CHECKSUM(SHA256) this package : 8be2195bb912a56995a0627a9a889fb343085d462e17cfaea7699b12b50080f0 CHECKSUM(SHA256) upstream package : 8be2195bb912a56995a0627a9a889fb343085d462e17cfaea7699b12b50080f0 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: edje-1.7.7/configure.ac:40 Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08 Buildroot used: fedora-rawhide-x86_64 Command line :./try-fedora-review -m fedora-rawhide-x86_64 -b 890771 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vcvSdvg1mc&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review