https://bugzilla.redhat.com/show_bug.cgi?id=965007 --- Comment #14 from Björn Esser <bjoern.esser@xxxxxxxxx> --- (In reply to Guillaume Kulakowski from comment #13) Hi Guillaume! Sorry for the little delay. :) > some question : > - Why modify github Source0 ? I have followed the guideline : > http://fedoraproject.org/wiki/Packaging:SourceURL#Github It was just meant a proposal, nothing mandatory. Both are fine with the guideline. My proposal makes things easier when it comes to updates; you won't have to look for new commit-sha, just adjust version-tag... > - %global __python %{__python3}. > OK, but with condition, because Gedit plugins on F18 use Python2. OK. Then just add the conditional. I'm fine with that. > - http://github.com/jonleighton/%{name} > Is compatible with readability guideline ? OK to use variable on Source0, > but I think that use variable on url and description harm to readability This goes fine with readability guidelines. I have it this way in my packages as well and nobody complained about it. I think having ONE macro in url-tag is ok, since it still makes sense when reading it --> url ends on pkg-name. > > Don't never-ever cloak your email-adress in spec-file... > Why ? Forget about it. Guidelines say it's OK. But on bugzilla your email-address is public viewable either... Just let me know, when I can start over with new spec/srpm... Cheers, Björn -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gRezPD7LbN&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review