https://bugzilla.redhat.com/show_bug.cgi?id=973084 Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mizdebsk@xxxxxxxxxx --- Comment #8 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> --- Disclaimer: I am not a sponsor of packager group so I can't do a formal review. I am adding comments as member of Java SIG and maintainer of Maven in Fedora. 1. You can use -f argument to %files macro. For example, instead of: %files %{_javadir}/%{name}.jar %{_mavendepmapfragdir}/%{name} %{_mavenpomdir}/JPP-%{name}.pom you can simply write %files -f .mfiles 2. The call to %add_maven_depmap can be simplified, just remove both arguments. 3. "rm -rf $RPM_BUILD_ROOT" is not needed and should be removed. (It would be needed for EPEL 5, but there is no Maven in EPEL.) 4. Group tags are not used in Fedora and can be removed. 5. Package descriptions should be wrapped up at 80 columns. (Other lines can be longer, but should also be kept short if possible.) 6. Instead of using unzip you can use jar utility. It is included with java-devel, so you wouldn't need to add BR on unzip. Basically remove that BR and s/unzip/jar xf/ in %prep. 7. To patch pom.xml files you are recommended to use %pom_* macros. Instead of adding patch a single line in prep would suffice: %pom_remove_plugin :maven-gpg-plugin -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ieNfgSCx8a&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review