[Bug 919933] Review Request: python-py2neo - A simple Python library that provides access to Neo4j

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=919933

--- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5521020

$ rpmlint -i -v *
python3-py2neo.noarch: I: checking
python3-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python3-py2neo.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

python-py2neo.noarch: I: checking
python-py2neo.noarch: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking
python-py2neo.src: I: checking-url http://py2neo.org/ (timeout 10 seconds)
python-py2neo.src: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
python-py2neo.spec: I: checking-url
https://pypi.python.org/packages/source/p/py2neo/py2neo-1.5.tar.gz (timeout 10
seconds)
3 packages and 1 specfiles checked; 0 errors, 1 warnings.



Some objections from my side:

A py3 version of a package should be standalone and shouldn't depend on the py2
version. You have to do the following:

* Don't remove the py3 scripts in /usr/bin. Rename and install them in the py
package.

* Rename the manpages for the py3 package to avoid package conflicts.

* The doc files may be present in both py2 and py3 packages.


Moreover, remove the executable bit again from the scripts in
%{python_sitelib}. Usually, no script there needs to be executable. Probably
you was a bit mislead by the shebangs, which you also have to remove from the
file headers. In doubt, ask the upstream developer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jF04zdRxWs&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]