https://bugzilla.redhat.com/show_bug.cgi?id=974889 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Test suite - I'd love to see the test suite executed during build, since it is quite important component and DB failures might result in data loss. - We are running test suite of rubygem-pg during build, so I'd love to see the test suite of rubygem-mysql2 executed as well. * License file in main package - The %{gem_instdir}/MIT-LICENSE should go into main package [1]. * Move only .so file into %{gem_extdir_mri} - Only the platform specific files belongs to %{gem_extdir_mri}, so you should do: mkdir -p %{buildroot}%{gem_extdir_mri}/lib/mysql2 mv %{buildroot}%{gem_instdir}/lib/mysql2/mysql2.so \ %{buildroot}%{gem_extdir_mri}/lib/mysql2 * Documentation should be marked as %doc - Please mark a documentation files (README.md MIT-LICENSE CHANGELOG.md) as a %doc. * rpmlint issues - There used to be bug in gem2rpm which causes: ./rubygem-mysql2.spec:48: W: macro-in-comment %gem_dir Please escape the macro properly. - Macros in comments should be escaped properly (but this gets solved as soon as the test suite will be executed during build ;) ./rubygem-mysql2.spec:68: W: macro-in-comment %{buildroot} ./rubygem-mysql2.spec:68: W: macro-in-comment %{gem_extdir_mri} [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wnrcsZPRwh&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review